ENH: maybe_convert_objects seen NaT speed-up #27300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 8, 2019
|
Will add. Should I add 'what's new' entry as well? Also - in which file should I add asv - algorithms.py? |
jreback
added
Performance
yes that would be great; 0.25.0 performance section. |
|
WillAyd
reviewed
Jul 9, 2019
doc/source/whatsnew/v0.25.0.rst
Outdated
| @@ -939,7 +939,7 @@ Performance improvements | |||
| - Improved performance by removing the need for a garbage collect when checking for ``SettingWithCopyWarning`` (:issue:`27031`) | |||
| - For :meth:`to_datetime` changed default value of cache parameter to ``True`` (:issue:`26043`) | |||
| - Improved performance of :class:`DatetimeIndex` and :class:`PeriodIndex` slicing given non-unique, monotonic data (:issue:`27136`). | |||
|
|
|||
| - Improved performance of :meth:`pandas._libs.lib.maybe_convert_objects` for the case when input contains ``NaT``. | |||
There was a problem hiding this comment.
Do you know what hits this from a user perspective? This is a private method which we wouldn’t mention in a what’snew
There was a problem hiding this comment.
What should I write instead?
There was a problem hiding this comment.
Depends on what would touch this from user code. I see DataFrame.from_tuples and maybe GroupBy ops with datetimelike objects in the result - do you see a difference when using either of those?
There was a problem hiding this comment.
best way is to run the entire asv suite (takes an hour or so)
and see what changes
|
I believe imports should be in this order: import pandas as pd
from pandas._libs import lib
from pandas.util import testing as tmBut when I run |
|
Also maybe add |
|
Full asv returns: So there are (somehow) downsides of it (or I am using Btw full |
|
Yea I think there is some noise in there - do some of the regressions even hit this code? |
|
ok so likely is this path is not hit in our asvs so remove the whatsnew note and looks good |
WillAyd
reviewed
Jul 9, 2019
| @@ -13,6 +15,19 @@ | |||
| pass | |||
|
|
|||
|
|
|||
| class MaybeConvertObjects: | |||
There was a problem hiding this comment.
Not sure we even need this benchmark since it doesn't indicate anything from end user experience but up to @jreback
Break alone in PR lgtm
There was a problem hiding this comment.
I want to add more tests here later as well - for more generalized cases.
jreback
approved these changes
Jul 9, 2019
|
thanks @BeforeFlight followups welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff